Skip to content

[SPARK-8374] [YARN] Job frequently hangs after YARN preemption#7128

Closed
xuchenCN wants to merge 5 commits intoapache:masterfrom
xuchenCN:SPARK-8374.1
Closed

[SPARK-8374] [YARN] Job frequently hangs after YARN preemption#7128
xuchenCN wants to merge 5 commits intoapache:masterfrom
xuchenCN:SPARK-8374.1

Conversation

@xuchenCN
Copy link
Contributor

@xuchenCN xuchenCN commented Jun 30, 2015

Issue description SPARK-8374

Application starve because YARN scheduler preemption.
This PR fix two issues

  1. Application starve because CoarseGrainedSchedulerBackend.removeExecutor was happened before HeartbeatReceiver.killExecutorThread

2.SpakrContext.killExecutor less executors than before BUT HeartbeatReceiver just want to expire the executor and expect new one

@xuchenCN xuchenCN mentioned this pull request Jun 30, 2015
Closed
@xuchenCN
Copy link
Contributor Author

xuchenCN commented Jun 30, 2015

CC @sryza

@andrewor14
Copy link
Contributor

andrewor14 commented Jun 30, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jul 1, 2015

Test build #36219 has finished for PR 7128 at commit c1fa754.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class Heartbeat(workerId: String, worker: RpcEndpointRef) extends DeployMessage
    • case class RegisteredWorker(master: RpcEndpointRef, masterWebUiUrl: String) extends DeployMessage
    • case class RegisterApplication(appDescription: ApplicationDescription, driver: RpcEndpointRef)
    • case class RegisteredApplication(appId: String, master: RpcEndpointRef) extends DeployMessage
    • case class SubmitDriverResponse(
    • case class KillDriverResponse(
    • case class MasterChanged(master: RpcEndpointRef, masterWebUiUrl: String)

@AmplabJenkins
Copy link

AmplabJenkins commented Jul 13, 2015

Can one of the admins verify this patch?

andrewor14
andrewor14 reviewed Jul 14, 2015
View reviewed changes
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala
Copy link
Contributor

@andrewor14 andrewor14 Jul 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a confusing name. Without reading the java docs I have no idea what the difference between killExecutor and expireExecutor is

@andrewor14
Copy link
Contributor

andrewor14 commented Jul 14, 2015

@xuchenCN The issue this patch is targeted for is a duplicate of SPARK-8119. There is already a fix for that in #7107. I believe the changes there are simpler and we should move forward with that one instead. Would you mind closing this PR?

@xuchenCN
Copy link
Contributor Author

xuchenCN commented Jul 15, 2015

@andrewor14 All right close this PR

@tgravescs
Copy link
Contributor

tgravescs commented Jul 20, 2015

@xuchenCN can you please close this then

@xuchenCN xuchenCN closed this Jul 21, 2015
@xuchenCN xuchenCN deleted the SPARK-8374.1 branch July 21, 2015 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuchenCN @andrewor14 @SparkQA @AmplabJenkins @tgravescs